Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from main #32

Draft
wants to merge 197 commits into
base: master
Choose a base branch
from
Draft

Merge from main #32

wants to merge 197 commits into from

Conversation

robin-phung
Copy link

Merge 9a0e280 from main into fork

macgena and others added 30 commits April 11, 2020 22:48
…ontrol

When using allow_multiple_experiments=control Split only allows one
experiment with an alternative other than 'control'.

Split::User#max_experiments_reached? checks for that looping through all
experiments. As Split::User#active_experiments drops the experiment
version we also need to do that here to be able to check properly.

Fixes #612
…ontrol-with-versions

Fix #max_experiments_reached? when using allow_multiple_experiments=control
Replace usage of SimpleRandom with RubyStats
…disabled

ab_test must return metadata on error or if split is disabled/excluded user
Introduce enable/disable experiment cohorting
Update Trial so that goals are accessible in callback
Remove thread_safe config as redis-rb is thread_safe by default since 2.2
Remove redis_url impl. Deprecated on ~2.2
andrehjr and others added 30 commits January 14, 2023 12:15
…n-warning

Fix deprecation warning with Redis 4.8.0
Add Ruby 3.2 to Github Actions
…-data

Do not throw error if alternativas have data that can lead to negative numbers for probability calculation
CROSSSLOT keys issue fix when using redis cluster
Convert value to string before saving it in RedisAdapter
…readme

Update documentation regarding finding users outside a web session
If a invalid value is persisted on a given alternative, that dashboard
is able to validate the data properly now.

Added a few specs to ensure extra_info is persisted correctly.

Co-authored-by: trostli <[email protected]>
Do not persist invalid extra_info on ab_record_extra_info.
Make specs compatible with newer rack
…havior

Fix context shim override behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.